Merged
Conversation
Member
Author
|
It'd be helpful to get a quick approval here. Thanks |
DilumAluthge
approved these changes
Jun 26, 2024
Member
DilumAluthge
left a comment
DilumAluthge
left a comment
There was a problem hiding this comment.
Oh interesting, I thought the release script would take care of this, but it seems like it doesn't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current dev instructions don't mention updating the version on master first. I think this has to be committed to master first, otherwise the version on master gets out of sync