Always print an error message, never error silently#262
Merged
DilumAluthge merged 2 commits intomasterfrom Jul 18, 2024
Merged
Conversation
DilumAluthge
force-pushed
the
dpa/never-error-silently
branch
from
4374e95 to
3b54df9
Compare
Member
Author
|
Bump @IanButterworth @omus. I think this PR is a strict improvement over the status quo, because (AFAICT) it makes sure that this action never errors without printing logs first. |
IanButterworth
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #240
Ref #241
This PR does NOT fix the actual problem in #240 or #241, but it does fix the problem of
setup-juliaerroring silently and not printing a log message.With this PR, as a general rule, we always print the error message before we throw the error.