Simplify the release process (no more build script or release branches)#281
Merged
DilumAluthge merged 9 commits intomasterfrom Sep 23, 2024
Merged
Simplify the release process (no more build script or release branches)#281DilumAluthge merged 9 commits intomasterfrom
DilumAluthge merged 9 commits intomasterfrom
Conversation
fedbeaf to
707e9cb
Compare
1299255 to
ee72db4
Compare
omus
reviewed
Sep 19, 2024
Contributor
|
I agree with the idea of checking in the built version |
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
…lso fails)" This reverts commit cd7944c.
Member
Author
|
@omus This is ready for another round of review. |
Member
Author
|
Bump @omus @IanButterworth |
IanButterworth
approved these changes
Sep 23, 2024
Member
IanButterworth
left a comment
There was a problem hiding this comment.
If you believe in this design I'm happy to move to it. I suggest you lead the next release so that if anything goes wrong we can be reactive in fixing it.
Member
Author
|
I just cut a new release ( We can quickly revert if something breaks. |
Member
Author
|
I also updated the |
Member
Author
|
From a quick test (JuliaLang/Example.jl#80), everything seems to be working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #280
After this PR, the release process of this repo becomes very simple:
vMAJOR.MINOR.PATCHtag locally (and push it).vMAJORtag locally (and force-push it).This is the exact same release process that is used in the
julia-actions/cacherepo1.So, by having the same release process across multiple repos, this should make things easier for maintainers.
Benefits:
Other benefits
useable. So, if someone wants to test out a PR before it is merged, they can simply douses: julia-actions/setup-julia@name-of-pr-branch.Footnotes
See the devdocs here: https://github.com/julia-actions/cache/blob/main/devdocs/making_a_new_release.md ↩