Add Support for Sparse Matrices in quadform()#726
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #726 +/- ##
==========================================
- Coverage 98.25% 98.20% -0.05%
==========================================
Files 88 88
Lines 5203 5121 -82
==========================================
- Hits 5112 5029 -83
- Misses 91 92 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think there is no Sparse Problem or they are converted into dense matrices. |
Yeah we need to add some new tests. |
|
I can formulate a problem. |
Refactor _squareroot function to _square_root and improve error handling.
Removed sparse matrix usage in quadform tests and added a new test case with a target reformulation.
|
It's just tooooo easy to make mistakes without tests. I swear when I write code without tests the probability that there is a bug is >99%. |
|
Could it be that the test has a bug :-)? I don't understand where |
|
Oops. I copy pasted from my local and didn’t get it all haha. See what I mean 😄 |
Add support for
SparseMatrixCSCinquadform().Fixes #725 .