Skip to content

Add Support for Sparse Matrices in quadform()#726

Merged
odow merged 8 commits intojump-dev:masterfrom
RoyiAvital:patch-1
Jan 19, 2026
Merged

Add Support for Sparse Matrices in quadform()#726
odow merged 8 commits intojump-dev:masterfrom
RoyiAvital:patch-1

Conversation

@RoyiAvital
Copy link
Copy Markdown
Contributor

Add support for SparseMatrixCSC in quadform().
Fixes #725 .

Add support for `SparseMatrixCSC` in `quadform()`.
Fixes #725 .
Add support for `SparseMatrixCSC` in `quadform()`.
Fixes #725 .
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.20%. Comparing base (6daf81c) to head (9235307).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
- Coverage   98.25%   98.20%   -0.05%     
==========================================
  Files          88       88              
  Lines        5203     5121      -82     
==========================================
- Hits         5112     5029      -83     
- Misses         91       92       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RoyiAvital
Copy link
Copy Markdown
Contributor Author

RoyiAvital commented Jan 16, 2026

I think there is no Sparse Problem or they are converted into dense matrices.
This is the reason the sparse path is not covered.

@odow
Copy link
Copy Markdown
Member

odow commented Jan 16, 2026

I think there is no Sparse Problem or they are converted into dense matrices. This is the reason the sparse path is not covered.

Yeah we need to add some new tests.

@RoyiAvital
Copy link
Copy Markdown
Contributor Author

I can formulate a problem.
Yet I am not sure where should I stick it and how.
Maybe the simplest path would be just wrap one existing one with sparse()?

odow added 3 commits January 19, 2026 16:18
Refactor _squareroot function to _square_root and improve error handling.
Removed sparse matrix usage in quadform tests and added a new test case with a target reformulation.
@odow
Copy link
Copy Markdown
Member

odow commented Jan 19, 2026

It's just tooooo easy to make mistakes without tests. I swear when I write code without tests the probability that there is a bug is >99%.

@RoyiAvital
Copy link
Copy Markdown
Contributor Author

Could it be that the test has a bug :-)? I don't understand where A is missing.

@odow
Copy link
Copy Markdown
Member

odow commented Jan 19, 2026

Oops. I copy pasted from my local and didn’t get it all haha. See what I mean 😄

@odow odow merged commit 98211f3 into jump-dev:master Jan 19, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Quad Form Fails with Sparse Matrix

2 participants