JEP-0011: Protobuf Introspection and Interface Generation#565
Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe JEP index README is updated: the Standards Track table is reformatted and a new row for JEP 0011 ("Protobuf Introspection and Interface Generation", status "Accepted", author "@kirkbrauer") is added; the hidden toctree is extended to include the JEP-0011 doc file. ChangesJEP Documentation Index
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@ambient-code Please update the TOCTREE and main index file for the JEPs to include this proposal. |
|
Done — added a JEPs index page at |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
python/docs/source/internal/jeps/index.md (1)
3-6: Consider linking the JEP process doc here.To reduce ambiguity for first-time proposal authors, add a direct link to the JEP process document in this intro section.
Based on learnings, the project’s process document is located at `jeps/JEP-0000-jep-process.md`.Suggested doc tweak
JEPs are the primary mechanism for proposing significant changes to Jumpstarter. Each JEP is submitted as a pull request containing a Markdown document that describes the motivation, design, and implementation plan for the proposed change. +For process details, see +[`JEP-0000: JEP Process`](../../../jeps/JEP-0000-jep-process.md).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@python/docs/source/internal/jeps/index.md` around lines 3 - 6, Add a direct link to the JEP process document in the intro paragraph of the JEP index so first-time authors can find the process easily; edit the text that begins "JEPs are the primary mechanism..." in the jeps index and append or replace a sentence with a clear relative link to the process doc (jeps/JEP-0000-jep-process.md) and a short phrase like "see the JEP process document" so readers can jump directly to the guidelines.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@python/docs/source/internal/jeps/index.md`:
- Around line 3-6: Add a direct link to the JEP process document in the intro
paragraph of the JEP index so first-time authors can find the process easily;
edit the text that begins "JEPs are the primary mechanism..." in the jeps index
and append or replace a sentence with a clear relative link to the process doc
(jeps/JEP-0000-jep-process.md) and a short phrase like "see the JEP process
document" so readers can jump directly to the guidelines.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a9f28d7f-141f-4ae5-b20b-88468446d8a2
📒 Files selected for processing (3)
python/docs/source/contributing.mdpython/docs/source/internal/jeps/JEP-0011-protobuf-introspection-interface-generation.mdpython/docs/source/internal/jeps/index.md
841f8ce to
abdcc59
Compare
|
@raballew @mangelajo I have updated the JEP proposal with a more refined scope focusing on just the Protobuf generation at build-time which is much simpler, deferring the interface generation for now, and addressing additional comments. |
mangelajo
left a comment
There was a problem hiding this comment.
Thank you !, very substantial work, and positive (of course with some risks of making things a little bit more complicated) but my opinion after fully reading it is that it's worth it.
My main question at this point is if we should really commit to deprecate the DriverCall or just keep it around forever to make development and out of tree drivers easier. I'd prefer to defer that decision until we are more familiar with this new path :)
Propose adding protobuf introspection to allow non-Python clients to discover driver APIs. Introduces FileDescriptorProto as the schema format and enables bidirectional CLI tooling (jmp proto export, jmp proto generate, jmp proto check).
…on-interface-generation.md Co-authored-by: Miguel Angel Ajo Pelayo <miguelangel@ajo.es>
…on-interface-generation.md Co-authored-by: Miguel Angel Ajo Pelayo <miguelangel@ajo.es>
079acd9 to
5fe576b
Compare
|
@mangelajo I've added the final refinements based on the comments, LGTM |
Propose adding protobuf introspection to allow non-Python clients to discover driver APIs. Introduces FileDescriptorProto as the schema format and enables bidirectional CLI tooling (jmp proto export, jmp proto generate, jmp proto check).
For a full reference implementation, please see: https://github.com/jumpstarter-dev/jumpstarter/tree/jep-11-protobuf-introspection