async-xeus-python - #29
Merged
Merged
Conversation
DerThorsten
marked this pull request as ready for review
April 13, 2026 07:46
|
|
||
| def __init__(self): | ||
| self.use_lock = True | ||
| self.run_cell_lock = asyncio.Lock() |
Member
There was a problem hiding this comment.
Is there a plan to support non locking calls? I don't see use_lock set anywhere else hee, nor in the companion PR in xeus-python.
Member
Author
There was a problem hiding this comment.
We can remove it. I chagned this value from a running interpreter for experimentation
| super(LiteHistoryManager, self).__init__(shell=shell, config=config, **traits) | ||
|
|
||
| class XPythonLoopRunner: | ||
| """A dummy loop runner for usage in XPywrapShell""" |
Member
There was a problem hiding this comment.
I guess you meant XPythonShell?
|
|
||
| async def run_cell_async(self, *args, **kwargs): | ||
| coro = super().run_cell_async(*args, **kwargs) | ||
| return |
Member
There was a problem hiding this comment.
Isn't it masked by the function defined line 135?
Member
Author
There was a problem hiding this comment.
indeed, I think this is some copy-paste-whatever lefteover that gets overwritten in 135.
good catch
JohanMabille
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.