Skip to content

Conversation

@mandre
Copy link
Collaborator

@mandre mandre commented Nov 14, 2025

Bump k8s libs to v0.34 and controller-runtime to v0.22.4.
Also removed upper version pin for gomega and text libs now that we're on go 1.24.

@github-actions github-actions bot added the semver:major Breaking change label Nov 14, 2025
@pierreprinetti
Copy link
Member

All those changes in the API interfaces: are there to comply with the new libraries? Did you do that by hand, or is it the result of a script?

@mandre
Copy link
Collaborator Author

mandre commented Nov 14, 2025

All those changes in the API interfaces: are there to comply with the new libraries? Did you do that by hand, or is it the result of a script?

They're the result of make generate. I should have said it in the commit message.

@mandre
Copy link
Collaborator Author

mandre commented Nov 20, 2025

go-apidiff flagged the following breaking change:

   Incompatible changes:
  - NewTypeConverter: changed from func(*k8s.io/apimachinery/pkg/runtime.Scheme) *k8s.io/client-go/testing.TypeConverter to func(*k8s.io/apimachinery/pkg/runtime.Scheme) k8s.io/apimachinery/pkg/util/managedfields.TypeConverter

I believe this is only for test (k8s.io/client-go/testing.TypeConverter) and can safely remove the semver:major tag.

@mandre mandre added semver:minor Backwards-compatible change and removed semver:major Breaking change labels Nov 20, 2025
@mandre mandre added this pull request to the merge queue Nov 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2025
Now that we've switched to go 1.24, we should drop the version pinning.
@mandre
Copy link
Collaborator Author

mandre commented Nov 20, 2025

I had to re-generate files after we merged the Domain controller.

@github-actions github-actions bot added semver:major Breaking change and removed semver:minor Backwards-compatible change labels Nov 20, 2025
@mandre mandre added semver:minor Backwards-compatible change and removed semver:major Breaking change labels Nov 20, 2025
@mandre mandre added this pull request to the merge queue Nov 20, 2025
Merged via the queue into k-orc:main with commit a126e23 Nov 20, 2025
12 checks passed
@mandre mandre deleted the bump-libs branch November 20, 2025 15:48
@mandre mandre added this to the Release 2.4 milestone Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:minor Backwards-compatible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants