Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions PROJECT
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,14 @@ resources:
kind: ServerGroup
path: github.com/k-orc/openstack-resource-controller/api/v1alpha1
version: v1alpha1
- api:
crdVersion: v1
namespaced: true
domain: k-orc.cloud
group: openstack
kind: Service
path: github.com/k-orc/openstack-resource-controller/api/v1alpha1
version: v1alpha1
- api:
crdVersion: v1
namespaced: true
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ kubectl delete -f $ORC_RELEASE
| security group (incl. rule) | | ✔ | ✔ |
| server | | ◐ | ◐ |
| server group | | ✔ | ✔ |
| service | | ✔ | ✔ |
| subnet | | ◐ | ◐ |
| volume | | ◐ | ◐ |
| volume type | | ◐ | ◐ |
Expand Down
78 changes: 78 additions & 0 deletions api/v1alpha1/service_types.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
/*
Copyright 2025 The ORC Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package v1alpha1

// ServiceResourceSpec contains the desired state of the resource.
type ServiceResourceSpec struct {
// name indicates the name of service. If not specified, the name of the ORC
// resource will be used.
// +optional
Name *OpenStackName `json:"name,omitempty"`

// description indicates the description of service.
// +kubebuilder:validation:MinLength:=1
// +kubebuilder:validation:MaxLength:=255
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// +optional
Description *string `json:"description,omitempty"`

// type indicates which resource the service is responsible for.
// +kubebuilder:validation:MinLength:=1
// +kubebuilder:validation:MaxLength:=255
// +required
Type string `json:"type,omitempty"`

// enabled indicates whether the service is enabled or not.
// +kubebuilder:default=true
// +optional
Enabled *bool `json:"enabled,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a default value (docs say it's optional), we want to make the field optional. If not, we should make it required and drop the pointer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although docs say its optional, I decided to define a default value because the schema defines it.

https://github.com/openstack/keystone/blob/master/keystone/catalog/backends/sql.py#L57

}

// ServiceFilter defines an existing resource by its properties
// +kubebuilder:validation:MinProperties:=1
type ServiceFilter struct {
// name of the existing resource
// +optional
Name *OpenStackName `json:"name,omitempty"`

// type of the existing resource
// +kubebuilder:validation:MinLength:=1
// +kubebuilder:validation:MaxLength:=255
// +optional
Type *string `json:"type,omitempty"`
}

// ServiceResourceStatus represents the observed state of the resource.
type ServiceResourceStatus struct {
// name indicates the name of service.
// +kubebuilder:validation:MaxLength:=255
// +optional
Name string `json:"name,omitempty"`

// description indicates the description of service.
// +kubebuilder:validation:MaxLength:=255
// +optional
Description string `json:"description,omitempty"`

// type indicates which resource the service is responsible for.
// +kubebuilder:validation:MaxLength:=255
// +optional
Type string `json:"type,omitempty"`

// enabled indicates whether the service is enabled or not.
// +optional
Enabled *bool `json:"enabled,omitempty"`
}
222 changes: 222 additions & 0 deletions api/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading