-
Notifications
You must be signed in to change notification settings - Fork 34
Keystone: support for Service controller #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| /* | ||
| Copyright 2025 The ORC Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1alpha1 | ||
|
|
||
| // ServiceResourceSpec contains the desired state of the resource. | ||
| type ServiceResourceSpec struct { | ||
| // name indicates the name of service. If not specified, the name of the ORC | ||
| // resource will be used. | ||
| // +optional | ||
| Name *OpenStackName `json:"name,omitempty"` | ||
|
|
||
| // description indicates the description of service. | ||
| // +kubebuilder:validation:MinLength:=1 | ||
| // +kubebuilder:validation:MaxLength:=255 | ||
| // +optional | ||
mandre marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| Description *string `json:"description,omitempty"` | ||
|
|
||
| // type indicates which resource the service is responsible for. | ||
| // +kubebuilder:validation:MinLength:=1 | ||
| // +kubebuilder:validation:MaxLength:=255 | ||
| // +required | ||
| Type string `json:"type,omitempty"` | ||
|
|
||
| // enabled indicates whether the service is enabled or not. | ||
| // +kubebuilder:default=true | ||
| // +optional | ||
| Enabled *bool `json:"enabled,omitempty"` | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If there's a default value (docs say it's optional), we want to make the field
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Although docs say its optional, I decided to define a default value because the schema defines it. https://github.com/openstack/keystone/blob/master/keystone/catalog/backends/sql.py#L57 |
||
| } | ||
|
|
||
| // ServiceFilter defines an existing resource by its properties | ||
| // +kubebuilder:validation:MinProperties:=1 | ||
| type ServiceFilter struct { | ||
| // name of the existing resource | ||
| // +optional | ||
| Name *OpenStackName `json:"name,omitempty"` | ||
|
|
||
| // type of the existing resource | ||
| // +kubebuilder:validation:MinLength:=1 | ||
| // +kubebuilder:validation:MaxLength:=255 | ||
| // +optional | ||
| Type *string `json:"type,omitempty"` | ||
| } | ||
|
|
||
| // ServiceResourceStatus represents the observed state of the resource. | ||
| type ServiceResourceStatus struct { | ||
| // name indicates the name of service. | ||
| // +kubebuilder:validation:MaxLength:=255 | ||
| // +optional | ||
| Name string `json:"name,omitempty"` | ||
|
|
||
| // description indicates the description of service. | ||
| // +kubebuilder:validation:MaxLength:=255 | ||
| // +optional | ||
| Description string `json:"description,omitempty"` | ||
|
|
||
| // type indicates which resource the service is responsible for. | ||
| // +kubebuilder:validation:MaxLength:=255 | ||
| // +optional | ||
| Type string `json:"type,omitempty"` | ||
|
|
||
| // enabled indicates whether the service is enabled or not. | ||
| // +optional | ||
| Enabled *bool `json:"enabled,omitempty"` | ||
| } | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The limit is 255 indeed: https://github.com/openstack/keystone/blob/19947349904082995b5477d4ec8272bf01f176b2/keystone/catalog/backends/sql.py#L53