Skip to content

Remove cert-manager copybara config post-upstream - #91

Open
ddelnano wants to merge 1 commit into
mainfrom
ddelnano/remove-cert-manager-copybara
Open

Remove cert-manager copybara config post-upstream#91
ddelnano wants to merge 1 commit into
mainfrom
ddelnano/remove-cert-manager-copybara

Conversation

@ddelnano

Copy link
Copy Markdown

Summary: Remove cert-manager copybara config post-upstream

These changes were upstreamed in pixie-io#2391 and pixie-io#2392

Relevant Issues: N/A

Type of change: /kind cleanup

Test Plan: Checked git diff between upstream and k8ss repo

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d6f29bcb-3da5-44de-a74b-9c22ec2b7ada

📥 Commits

Reviewing files that changed from the base of the PR and between 5a07264 and 54caad1.

📒 Files selected for processing (1)
  • tools/private/copybara/copy.bara.sky

📝 Walkthrough

Walkthrough

The Copybara configuration narrows Kubernetes ignore rules to k8s/vizier/BUILD.bazel and removes exclusions for scripts/create_cloud_secrets.sh and src/utils/shared/certs/**.

Changes

Copybara filter updates

Layer / File(s) Summary
Narrow synchronization exclusions
tools/private/copybara/copy.bara.sky
The ignored_dirs configuration replaces the broad k8s/** rule with k8s/vizier/BUILD.bazel and removes exclusions for the secrets script and shared certificates subtree.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • k8sstormcenter/pixie#75: Updates the same Copybara ignore configuration with narrower Kubernetes-specific exclusions.

Suggested reviewers: entlein

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the cleanup theme and Copybara config change, though it is broader than the exact diff.
Description check ✅ Passed The description matches the Copybara cleanup and upstreaming context, so it is clearly related to the changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch ddelnano/remove-cert-manager-copybara
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ddelnano/remove-cert-manager-copybara

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant