feat: sync unattend engine to bf13991 — drop WDAC, add PE image/dism options, v0.1.4-alpha polish - #28
Merged
Merged
Conversation
- Updated Optimizations.cs to streamline the disabling of Windows Defender by removing unnecessary checks and scripts. - Removed Wdac.cs and associated resources as they are no longer needed. - Deleted DisableDefender.vbs and known-writeable-folders.txt as part of the cleanup. - Simplified ProductKey.cs by removing unused interfaces and logic related to installation settings. - Adjusted autounattend.xml to remove obsolete ImageInstall section. - Enhanced UnattendXmlBuilderTests to cover new disk handling and source image selection scenarios.
…urce image sections
- Added a filter for a glow effect on the SVG trail in index.html to enhance visual appeal. - Refactored scroll.js to improve scroll detection and smooth scrolling behavior, ensuring the "go-top" button works correctly with inner scrollable elements. - Updated theme.js to remove unnecessary animations on page transitions, relying on the native View Transitions API for smoother navigation. - Implemented a click interceptor in view-transitions.js to manage internal navigation with a crossfade effect, improving user experience during SPA transitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Re-syncs the vendored
cschneegans/unattend-generatorengine to upstreambf13991(2026-05-22) and adapts the app to its reworked API, plus a round of UX polish and a
version bump to
v0.1.4-alpha.Engine / generator:
srcs/Preflight.Unattend/to upstreambf13991(mechanicalre-copy; csproj customizations preserved,
NOTICErecords the SHA).section, mapper, registry entry, resx strings and docs are gone.
IPESettings: partitioning, installimage and the dism step now nest under
Configuration.PESettings.MapDisk→MapPe(Interactive →DefaultPESettings, AutoWipe/CustomScript →GeneratePESettings).setup" mode + "Skip image integrity check" toggle, Compact OS, Disable Defender,
8.3-name + pause toggles. Dropped the now-unsupported "recovery inside Windows
partition" option and the install-partition index.
UX / polish:
that the old gap-cloak strip caused over the ambient glow).
offset-path)after it had been flattened to a plain line.
🏷️ Type of change
feat- new featurefix- bug fixdocs- documentationrefactor- code change, no new feature / no fixperf- performance improvementtest- add or fix testschore- tooling, config, CI, deps💬 Notes for reviewers
Preflight.App/Servicesadapters,never in
srcs/Preflight.Unattend/. The sync was a mechanical copy;AssemblyName= UnattendGeneratoris load-bearing (Bloatware.json$type) and was preserved.a
Wdackey still import (deserializer skips unknown members; the importer's try/catchdegrades a stale removed-enum value to a warning rather than crashing).
when the disk is managed (auto-wipe / custom script) — inherent to the upstream PE design.
Disk_AutoWipe_*was rewritten: the engine now emits a PE.cmddiskpart scriptinstead of
<DiskConfiguration>/<InstallTo>. Added coverage for/Index:,/Name:and the
/CheckIntegritytoggle.change; reviewers may want to skim those commits separately.
dotnet build Preflight.slnxclean (0 warnings), 35/35 tests pass.