Skip to content

feat: Enable feature flag for Helm secret creation#441

Merged
EItanya merged 4 commits into
kagent-dev:mainfrom
abhinav-1305:feature/helm-secret-flag
May 29, 2025
Merged

feat: Enable feature flag for Helm secret creation#441
EItanya merged 4 commits into
kagent-dev:mainfrom
abhinav-1305:feature/helm-secret-flag

Conversation

@abhinav-1305
Copy link
Copy Markdown
Contributor

@abhinav-1305 abhinav-1305 commented May 27, 2025

Resolves: #345

@abhinav-1305 abhinav-1305 changed the title Add: Helm secret creation feature flag feat: Enable feature flag for Helm secret creation May 27, 2025
@EItanya
Copy link
Copy Markdown
Contributor

EItanya commented May 27, 2025

Can you please reference the issue you are resolving so that it will be automatically closed when this merges. You can do this by adding in the PR description: resolves #...

@EItanya
Copy link
Copy Markdown
Contributor

EItanya commented May 28, 2025

@Matcham89 does this close out the issue for you?

@Matcham89
Copy link
Copy Markdown
Contributor

@EItanya checking now :)

@Matcham89
Copy link
Copy Markdown
Contributor

@EItanya @abhinav-1305
I believe so.
Since the apiKeySecretKey: and apiKeySecretRef: now sit in the ModelConfig, as long as both are provided in the Values it will consume my external secret.

Id say looks good

@abhinav-1305
Copy link
Copy Markdown
Contributor Author

Thanks @Matcham89 for testing ,@EItanya, can we merge this now?

@EItanya EItanya merged commit a06fb17 into kagent-dev:main May 29, 2025
9 checks passed
@abhinav-1305 abhinav-1305 deleted the feature/helm-secret-flag branch May 29, 2025 14:53
Raghavendiran-2002 pushed a commit to Raghavendiran-2002/kagent that referenced this pull request Apr 30, 2026
…apiKey in base64 (kagent-dev#441)

Co-authored-by: Abhinav kumar <126642111+Abhinavcode13@users.noreply.github.com>
Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Helm Secret Creation Feature Flag

4 participants