Code changes for Singleton and Builder Pattern assignment - #9
Open
venu123 wants to merge 3 commits into
Open
Conversation
kanmaytacker
requested changes
Sep 18, 2023
| this.instance = new DatabaseConfigurationBuilder(); | ||
| } | ||
|
|
||
| public DBConfigBuilder WithDatabaseUrl(String url){ |
Owner
There was a problem hiding this comment.
[Minor] Java uses camel case so a method name should look like withDatabaseUrl.
Read more about it here.
Comment on lines
+59
to
+61
| public DatabaseConfigurationBuilder build(){ | ||
| return instance; | ||
| } |
Owner
There was a problem hiding this comment.
Rather than returning the builder instance back, create an new object and return that.
This ensures immutability and isolation.
venu123
changed the title
venu123
commented
Sep 19, 2023
venu123
left a comment
venu123
left a comment
Author
There was a problem hiding this comment.
Please review change for singleton
kanmaytacker
self-requested a review
October 4, 2023 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes for Builder Pattern assignment