Options dialog for plugin, and bug fixes for multiple tabs and plugin unloading.#5
Open
mesilliac wants to merge 3 commits intokapouer:masterfrom
Open
Options dialog for plugin, and bug fixes for multiple tabs and plugin unloading.#5mesilliac wants to merge 3 commits intokapouer:masterfrom
mesilliac wants to merge 3 commits intokapouer:masterfrom
Conversation
Previously all updates were applying to the currently active view.
The dialog is integrated with gedit's plugin chooser. Options are: * guess_tabs: whether or not to guess document indent settings. * convert_paste: whether to convert clipboard text indentation.
Owner
|
Cool, i've installed your PR locally. If everything's all right i'll merge soon (but now i'm often using gnome-builder so it will take some days before i'm sure it works as expected). |
|
Fork works well for me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each in a separate commit... the big change is the options dialog. Integrating with GSettings was difficult while maintaining the ability to just drop the plugin in the
~/.local/share/gedit/pluginsdirectory, so i wrote a simple config file saver / loader to save the options. It saves config as~/.config/gedit/autotab.The options are currently:
In addition to this there were a couple bugfixes.
Bugfix one: The clipboard paste handler wasn't being properly disconnected when deactivating the plugin.
Bugfix Two: When multiple tabs were open the tab settings were being applied always to the active tab, in stead of the one actually being parsed. This resulted in various problems when the plugin was activated with multiple tabs open.