Seprate Viber tags with spaces#224
Merged
karlicoss merged 3 commits intokarlicoss:masterfrom Apr 1, 2021
Merged
Conversation
karlicoss
requested changes
Mar 31, 2021
Owner
karlicoss
left a comment
karlicoss
left a comment
There was a problem hiding this comment.
Looks good, just one comment!
macos-latest, 3.6 pipeline failed, but looks like a random github glitch, will probably go away on next change
Owner
|
looks ok, but think it conflicts with the previous PR merged before -- so needs a rebase/conflict resolution |
+ Add Doctest - hyp: inline in-text visits (mypy api didn't worth it).
Contributor
Author
|
Resolved conflict and did some suggested nit picks in #222. |
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...like hypothesis-source does.
Also use JSON1 SQLite extension to extract items from a JSON column.