Skip to content

firefox updates#227

Merged
karlicoss merged 2 commits intomasterfrom
updates
Apr 14, 2021
Merged

firefox updates#227
karlicoss merged 2 commits intomasterfrom
updates

Conversation

@karlicoss
Copy link
Owner

No description provided.

@karlicoss karlicoss merged commit 1bb47d7 into master Apr 14, 2021
@karlicoss karlicoss deleted the updates branch April 14, 2021 18:37
@purarue
Copy link
Contributor

purarue commented Apr 17, 2021

Uh, just curious

was there any reason to include this in the shared _row2visit_firefox function and not create separate handlers for the datetime part of Firefox and FirefoxPhone?

Just less ability to share it as a classmethod?

@karlicoss
Copy link
Owner Author

karlicoss commented Apr 17, 2021

So interesting enough, Fenix (beta Firefox) actually has the same schema as desktop Firefox (so already was matching class Firefox, not class FirefoxPhone).
But still seems that there might be subtle schema differences like this one 🤷 Figured it wasn't worth duplicating most of class Firefox to class FirefoxPhoneNew or something like that.

whoops, just noticed accidental print


wonder if this is how you noticed it xD

@purarue
Copy link
Contributor

purarue commented Apr 17, 2021

Ah, no, I've still been trying to figure out how to backup my firefoxphone db using termux, am very new to that

as im currently using a mix of ffexport and some 'private' promnesia stuff to merge my browsing history in HPI, is getting a bit annoying to manage...

Can't really just use promnesia because I want access to the description/title/image that firefox exposes; but understandably that wouldn't be needed in promnesia

So, spent a few hours restructuring ffexport to a namespace package to allow it to be more extendible, so it supports firefox derivates etc, was reading over the code here and noticed the recent changes

@purarue
Copy link
Contributor

purarue commented Apr 17, 2021

I guess one major difference is that the Extr class Im defining also describes how to backup the databases

But otherwise that project and promnesia are pretty similar, some code duplication as far as detecting/reading from databases goes

Is what I was using before promnesia becuase I still wanted to backup my history, but promnesia seemed a bit daunting whilst I was still building HPI out

Plan to create a similarieis/difference thing in the readme

@karlicoss
Copy link
Owner Author

Nice! I mean if it's flexible enough then ffexport can just be used in promnesia, right? Would be cool to move this outside.

@purarue
Copy link
Contributor

purarue commented Apr 17, 2021

Once its a bit more stable than it is currently, I wouldn't be opposed to trying to replace browser.py and the browser_history.py script

@ankostis
Copy link
Contributor

Indeed now browser_history.py is deprecated, but i cannot find instructions how to accomplish the same promnesia-update task with [browser.py](https://github.com/seanbreckenridge/browserexport ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants