sources.smscalls: propogate errors if there are breaking schema changes#386
Merged
karlicoss merged 1 commit intokarlicoss:masterfrom Apr 15, 2023
Merged
Conversation
781b735 to
22a434f
Compare
Owner
|
I think mypy can complain about unnecessary None checks, but it's a custom flag which we don't have :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to: karlicoss/HPI#289
Am unsure if CI here will fail till the return type from HPI is updated, but I think the change is small enough should be able to merge after publishing a release there...
Just to show works locally with new types: