Skip to content

sources.smscalls: propogate errors if there are breaking schema changes#386

Merged
karlicoss merged 1 commit intokarlicoss:masterfrom
purarue:smscalls-handle-result
Apr 15, 2023
Merged

sources.smscalls: propogate errors if there are breaking schema changes#386
karlicoss merged 1 commit intokarlicoss:masterfrom
purarue:smscalls-handle-result

Conversation

@purarue
Copy link
Contributor

@purarue purarue commented Apr 15, 2023

related to: karlicoss/HPI#289

Am unsure if CI here will fail till the return type from HPI is updated, but I think the change is small enough should be able to merge after publishing a release there...

Just to show works locally with new types:

$ mypy -p promnesia.sources.smscalls
Success: no issues found in 1 source file

$ hpi doctor -S promnesia.sources.smscalls
✅ OK  : promnesia.sources.smscalls                        
✅     - stats: {'index': {'index': {'count': 371, 'last': datetime.datetime(2023, 4, 14, 20, 6, 18, 459000, tzinfo=datetime.timezone.utc)}}}

@purarue purarue force-pushed the smscalls-handle-result branch from 781b735 to 22a434f Compare April 15, 2023 06:09
@karlicoss
Copy link
Owner

I think mypy can complain about unnecessary None checks, but it's a custom flag which we don't have :)

@karlicoss karlicoss merged commit f8525e7 into karlicoss:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants