sources.takeout: add support for new youtube csv format#436
sources.takeout: add support for new youtube csv format#436karlicoss merged 3 commits intokarlicoss:masterfrom
Conversation
|
hmm, looks like hypothesis test data may be gone: |
|
Yeah also just noticed the CI stuff -- fixed here karlicoss/hypexport@b9f1cab (has some explanation why I used a submodule in the first place). If you rebase should hopefully all good! |
|
And thanks for the change! Haven't seen this data yet I think, but haven't done exports for some months that way the rest of the code with |
|
yep, gotcha im a bit busy for the next few days but will get to that when I have some time |
|
have not tested on old version yet, but I think something like this should work will test on old/new versions of google_takeout_parser later and let you know does look like it at least works on new version: |
|
whoops, forgot to press merge! thanks |
google takeout recently changed the format to CSV files for youtube comments, I added support for it to google_takeout_parser a few weeks ago.
I haven't taken a stab at trying to de-dupe comments that exist in the old HTML format and the new CSV one yet, it is on my todos, but I thought it would be good to get this in here so that new people making an export can at least get access to their comments. There might be some duplication but better than erroring or not existing
this is very basic right now, it does not have any error checking, so if the user is on an old version of
google_takeout_parser, this will just error. Should I add a warning message in the ImportError reminding them to upgrade? Wasnt sure if that was too muchIf theres anything else you think should be changed/added for this, let me know