This repository was archived by the owner on May 12, 2021. It is now read-only.
Limitations: Remove seccomp limitation.#342
Merged
Merged
Conversation
jodh-intel
approved these changes
Jan 7, 2019
jodh-intel
left a comment
jodh-intel
left a comment
There was a problem hiding this comment.
A couple of nits but generally...
lgtm
| We only support --security-opt=no-new-privileges option as of today. | ||
|
|
||
| See https://github.com/kata-containers/kata-containers/issues/31 for more information. | ||
| We only support --security-opt=no-new-privileges and security-opt seccomp=/path/to/seccomp/profile.json |
There was a problem hiding this comment.
Missing dashes: --security-opt seccomp=/path/to/seccomp/profile.json.
Also -- although not strictly part of this PR -- it might be worth rendering these options in backticks:
We only support
--security-opt=no-new-privilegesand--security-opt seccomp=/path/to/seccomp/profile.json...
| We only support --security-opt=no-new-privileges and security-opt seccomp=/path/to/seccomp/profile.json | ||
| option as of today. | ||
|
|
||
| Note: The `--security-opt apparmor=your_profile` is yet not supported. See https://github.com/kata-containers/runtime/issues/707 |
There was a problem hiding this comment.
- I think "not yet" rather than "yet not" ready more clearly.
- Nit: Missing period at end of sentence.
Document that seccomp support is now available. FIxes: #341 Signed-off-by: Nitesh Konkar niteshkonkar@in.ibm.com
Contributor
Author
|
Thanks, @jodh-intel , Fixed! |
|
Thanks @nitkon ! ;) |
Contributor
|
Doh, this was nominally blocked on the merge of kata-containers/runtime#689, but that was only noted in the Issue, and there was no DNM on this PR. |
devimc
pushed a commit
to devimc/kata-documentation
that referenced
this pull request
Sep 2, 2019
Add kmod package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document that seccomp support is now available.
FIxes: #341
Signed-off-by: Nitesh Konkar niteshkonkar@in.ibm.com