Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

versions: Update supported cri-o version#436

Closed
chavafg wants to merge 1 commit into
kata-containers:masterfrom
chavafg:topic/crio-version
Closed

versions: Update supported cri-o version#436
chavafg wants to merge 1 commit into
kata-containers:masterfrom
chavafg:topic/crio-version

Conversation

@chavafg

@chavafg chavafg commented Jun 21, 2018

Copy link
Copy Markdown
Contributor

We need to update the cri-o version to the
HEAD of the release-1.10 branch, which contains a fix
to be able to test cri-o with devicemapper using a
block device.

Fixes #435.

Signed-off-by: Salvador Fuentes salvador.fuentes@intel.com

@katacontainersbot

katacontainersbot commented Jun 21, 2018

Copy link
Copy Markdown
Contributor

PSS Measurement:
Qemu: 148078 KB
Proxy: 4605 KB
Shim: 8861 KB

Memory inside container:
Total Memory: 2045972 KB
Free Memory: 2007308 KB

@chavafg chavafg force-pushed the topic/crio-version branch from 448f564 to ffd6110 Compare June 21, 2018 20:29
@katacontainersbot

katacontainersbot commented Jun 21, 2018

Copy link
Copy Markdown
Contributor

PSS Measurement:
Qemu: 146824 KB
Proxy: 4596 KB
Shim: 8869 KB

Memory inside container:
Total Memory: 2045972 KB
Free Memory: 2007432 KB

@jcvenegas

jcvenegas commented Jun 21, 2018

Copy link
Copy Markdown
Member

lgtm

amshinde
amshinde approved these changes Jun 21, 2018
View reviewed changes

@amshinde amshinde left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amshinde

amshinde commented Jun 21, 2018

Copy link
Copy Markdown
Member

@chavafg CI is failing

# time="2018-06-21T20:57:17Z" level=error msg="error opening storage: /dev/vdb is already part of a volume group "storage": must remove this device from any volume group or provide a different device"

@chavafg

chavafg commented Jun 21, 2018

Copy link
Copy Markdown
Contributor Author

@amshinde yes, I forgot to export $LVM_DEVICE on the test PR, just repushed, this time it should work

@jodh-intel

jodh-intel commented Jun 22, 2018 •
edited by amshinde
Loading

Copy link
Copy Markdown

lgtm

Approved with PullApprove

@chavafg chavafg force-pushed the topic/crio-version branch from ffd6110 to 472b199 Compare June 22, 2018 20:29
@katacontainersbot

katacontainersbot commented Jun 22, 2018

Copy link
Copy Markdown
Contributor

PSS Measurement:
Qemu: 142386 KB
Proxy: 4675 KB
Shim: 9089 KB

Memory inside container:
Total Memory: 2045972 KB
Free Memory: 2007308 KB

@chavafg chavafg force-pushed the topic/crio-version branch from 472b199 to 1cf8d2e Compare June 22, 2018 22:50
@katacontainersbot

katacontainersbot commented Jun 22, 2018

Copy link
Copy Markdown
Contributor

PSS Measurement:
Qemu: 142249 KB
Proxy: 4667 KB
Shim: 8884 KB

Memory inside container:
Total Memory: 2045972 KB
Free Memory: 2007300 KB

@codecov

codecov Bot commented Jun 22, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   63.99%   63.99%           
=======================================
  Files          87       87           
  Lines        8801     8801           
=======================================
  Hits         5632     5632           
  Misses       2564     2564           
  Partials      605      605

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9377548...09fb56c. Read the comment docs.

@jodh-intel

jodh-intel commented Jun 25, 2018

Copy link
Copy Markdown

Hi @chavafg - we've got a clean CI run so can we now remove the dnm label?

@chavafg

chavafg commented Jun 25, 2018

Copy link
Copy Markdown
Contributor Author

Hi,

I've changed the cri-o version from being the latest head of the release-1.10 branch to 66788a10e57f42faf741c2f149d0ee6635063014 which is a commit from the 1.11-dev release. I re-ran the CI over the weekend and it seems that the problem is gone.
Want consensus if it is ok to move to this 1.11-dev version?
/cc @jodh-intel @sboeuf @grahamwhaley @amshinde @egernst

@sboeuf

sboeuf commented Jun 25, 2018

Copy link
Copy Markdown

@chavafg which problem ? Are you talking about sporadic CRI-O failures ?
Also, moving to 1.11 means we have to move to k8s 1.11, right ? Isn't it a big change ?

@jcvenegas

jcvenegas commented Jun 26, 2018

Copy link
Copy Markdown
Member

lgtm

@jcvenegas

jcvenegas commented Jun 26, 2018

Copy link
Copy Markdown
Member

@chavafg I am fine if we can unlock the CI but we still need a plan to make sure latest cri-o release works.

@chavafg chavafg force-pushed the topic/crio-version branch from 1cf8d2e to 4b0ba0d Compare June 29, 2018 03:30
@chavafg
versions: Update supported cri-o version
09fb56c 
We need to update the cri-o version to the
HEAD of the release-1.10 branch, which contains a fix
to be able to test cri-o with devicemapper using a
block device.

Fixes kata-containers#435.

Depends-on: github.com/kata-containers/tests#457

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
@chavafg chavafg force-pushed the topic/crio-version branch from 4b0ba0d to 09fb56c Compare June 29, 2018 03:35
@katacontainersbot

katacontainersbot commented Jun 29, 2018

Copy link
Copy Markdown
Contributor

PSS Measurement:
Qemu: 148751 KB
Proxy: 4713 KB
Shim: 8766 KB

Memory inside container:
Total Memory: 2045968 KB
Free Memory: 2007228 KB

@chavafg

chavafg commented Jun 30, 2018

Copy link
Copy Markdown
Contributor Author

closing as #454 will address this.

@chavafg chavafg closed this Jun 30, 2018
@chavafg chavafg deleted the topic/crio-version branch July 12, 2018 14:12
zklei pushed a commit to zklei/runtime that referenced this pull request Jun 13, 2019
Merge pull request kata-containers#436 from marcov/libcontainer-tmp
29f3fe9 
libcontainer: use /run as root containers path
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@amshinde amshinde amshinde approved these changes
@sboeuf sboeuf sboeuf approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update cri-o supported version

6 participants

@chavafg @katacontainersbot @jcvenegas @amshinde @jodh-intel @sboeuf