Fix Remux Dolby Vision MKVs task with Jellyfin 10.11 by avoiding GetUserByName#13
Closed
MrHumanRebel wants to merge 3 commits intokatiekloss:mainfrom
MrHumanRebel:main
Closed
Fix Remux Dolby Vision MKVs task with Jellyfin 10.11 by avoiding GetUserByName#13MrHumanRebel wants to merge 3 commits intokatiekloss:mainfrom MrHumanRebel:main
MrHumanRebel wants to merge 3 commits intokatiekloss:mainfrom
MrHumanRebel:main
Conversation
…y-for-jellyfin Update Jellyfin 10.11 compatibility
Owner
|
Thanks for the updates! I think the "missing method" error is a bit misleading, because the method wasn't actually removed. The most recent version of the plugin was built for Jellyfin 10.10, and the (the order of declared methods might have changed, I think that can affect how the runtime picks targets.) Rebuilding against 10.11.0 and .NET 9 appears to resolve the problem without any other code changes (though I have yet to test it), so I'm going to close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
Remux Dolby Vision MKVsscheduled task failing on Jellyfin 10.11.x with aMissingMethodException:Jellyfin 10.11 removed or changed
IUserManager.GetUserByName(string), so the plugin crashes as soon as the scheduled task runs.Fixes #12.
Changes
RemuxLibraryTaskto resolve the configured Primary User without calling the removedIUserManager.GetUserByName(string)method.configuration.PrimaryUser,_userManager.UsersbyName,The rest of the task logic (item query, remux conditions, FFmpeg invocation, etc.) is unchanged.