Skip to content

Added Debug trait to error::Error#2

Merged
kayleg merged 1 commit intomasterfrom
ta/fix/errorTraits
Jun 21, 2019
Merged

Added Debug trait to error::Error#2
kayleg merged 1 commit intomasterfrom
ta/fix/errorTraits

Conversation

@tehAnswer
Copy link
Collaborator

@tehAnswer tehAnswer commented Jun 15, 2019

Hey @kayleg,

This pull request that adds the Debug trait to cloud_pub::error::Error and consequently, the unwrap method to anyResult instances containing this error type.

More info here.

@tehAnswer tehAnswer requested a review from kayleg June 15, 2019 12:52
Copy link
Owner

@kayleg kayleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kayleg kayleg merged commit 3825ac8 into master Jun 21, 2019
@kayleg kayleg deleted the ta/fix/errorTraits branch June 21, 2019 04:18
kayleg pushed a commit that referenced this pull request Oct 22, 2021
* This fix changes the returned values from `get_messages` from a tuple of
vectors with ack_ids and message, to a HashMap where ack_id is stored
with a Result that contains either the successfully deserialized message
or the error that occurred.

Co-authored-by: Robert Walker <robert@walker.st>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants