Skip to content

Conversation

@pratik-mahalle
Copy link
Contributor

@pratik-mahalle pratik-mahalle commented Sep 24, 2025

What has changed?

Please include a summary of the change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Documentation update (if none of the other choices apply).

How Has This Been Tested?

Please run npm run build and npm run serve to check if the changes are working as expected. Please include screenshots of the output of both the commands. Add screenshots/gif of the changes if possible.

Screenshot 2025-09-24 at 2 35 50 PM

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.

HifzaanDev and others added 6 commits September 18, 2025 06:30
Signed-off-by: kenk999 <mohammadhifzan24@gmail.com>
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
Copilot AI review requested due to automatic review settings September 24, 2025 09:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the Java quickstart documentation and images to improve clarity and accuracy of the documentation.

  • Updates image references to use more descriptive filenames
  • Fixes documentation headers and text formatting
  • Streamlines command instructions by combining git clone and cd operations

Reviewed Changes

Copilot reviewed 7 out of 22 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
versioned_docs/version-3.0.0/server/installation_tabs.md Updates Docker installation header for clarity on WSL
versioned_docs/version-3.0.0/quickstart/samples-java.md Updates image references to use more descriptive filenames
versioned_docs/version-3.0.0/quickstart/java-spring-postgres.md Updates image references for PostgreSQL quickstart
versioned_docs/version-3.0.0/quickstart/java-spring-boot-xml.md Replaces GitHub asset images with local documentation images
versioned_docs/version-3.0.0/quickstart/java-spring-boot-openhospital.md Adds cd commands and updates image references
versioned_docs/version-3.0.0/keploy-explained/testing-guide.md Fixes header formatting
versioned_docs/version-2.0.0/quickstart/java-spring-boot-openhospital.md Combines git clone and cd commands

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 42 to +43
git clone https://github.com/keploy/openhospital-core
cd openhospital-core/
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git clone and cd commands should be combined into a single line for consistency with the pattern used in version 2.0.0, as git clone https://github.com/keploy/openhospital-core && cd openhospital-core/.

Suggested change
git clone https://github.com/keploy/openhospital-core
cd openhospital-core/
git clone https://github.com/keploy/openhospital-core && cd openhospital-core/

Copilot uses AI. Check for mistakes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the Copilot review @pratik-mahalle

Comment on lines 56 to +57
git clone https://github.com/keploy/openhospital-api
cd openhospital-api/
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git clone and cd commands should be combined into a single line for consistency, as git clone https://github.com/keploy/openhospital-api && cd openhospital-api/.

Suggested change
git clone https://github.com/keploy/openhospital-api
cd openhospital-api/
git clone https://github.com/keploy/openhospital-api && cd openhospital-api/

Copilot uses AI. Check for mistakes.
Comment on lines 82 to +84
git clone https://github.com/keploy/openhospital-ui
cd openhospital-ui/
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git clone and cd commands should be combined into a single line for consistency, as git clone https://github.com/keploy/openhospital-ui && cd openhospital-ui/.

Suggested change
git clone https://github.com/keploy/openhospital-ui
cd openhospital-ui/
git clone https://github.com/keploy/openhospital-ui && cd openhospital-ui/

Copilot uses AI. Check for mistakes.
pratik-mahalle and others added 2 commits September 30, 2025 13:00
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
Copy link
Member

@Achanandhi-M Achanandhi-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In this blog, we will learn how test bench of keploy works and how you can contribute to keploy's code coverage.

## Keploy test Keploy?
## Keploy Test?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this we don't want to change this line @pratik-mahalle

Comment on lines 42 to +43
git clone https://github.com/keploy/openhospital-core
cd openhospital-core/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the Copilot review @pratik-mahalle

## Install Keploy with Docker on Windows
## Install Keploy with Docker on WSL

1. **Make sure Docker is installed** : You’ll need **Docker Desktop** running on Windows.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the Docker Desktop running on windows ? Include only Docker installed. Also update in other places where windows is used changed to wsl in the docker installation for windows

@Achanandhi-M Achanandhi-M merged commit 08d5466 into keploy:main Oct 6, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants