Fix BrowsersService.Get interface to match SDK #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update FakeBrowsersService struct and Get method to include the new kernel.BrowserGetParams parameter, matching the SDK update in the BrowsersService interface.
github-actions
bot
force-pushed
the
ci-fix/cli-coverage-update
branch
from
f7423d6 to
cf2dd29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Aligns test fakes with the updated SDK
BrowsersService.Getsignature.FakeBrowsersService.Getto acceptquery kernel.BrowserGetParamsand update its implementationGet(e.g.,BrowsersView,BrowsersGet, logs/replays/process/fs/computer helpers) to use the new parameterWritten by Cursor Bugbot for commit cf2dd29. This will update automatically on new commits. Configure here.