test: add unit tests for HardwareDetailsCommitHistoryView #1704
+191
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavobtflores
added
the
CI/CD
MarceloRobert
approved these changes
Jan 21, 2026
Collaborator
MarceloRobert
left a comment
MarceloRobert
left a comment
There was a problem hiding this comment.
All good, just some nits but I'll pre-approve
| @patch( | ||
| "kernelCI_app.views.hardwareDetailsCommitHistoryView.get_hardware_commit_history" | ||
| ) | ||
| def test_get_hardware_details_commit_history_returns_table_when_rows_valid( |
Collaborator
There was a problem hiding this comment.
nit: this should be the first test since it is a real "succes" test, and also it's currently in the middle of "response error" test cases
| ) | ||
| response = self.view.post(request, hardware_id="1") | ||
|
|
||
| self.assertEqual(response.status_code, 200) |
Collaborator
There was a problem hiding this comment.
very nit: you could use HTTPStatus.OK or HTTPStatus.BAD_REQUEST for the response codes instead of magic numbers
gustavobtflores
force-pushed
the
test/hardware-details-commit-history
branch
from
8116f49 to
3acf4fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds missing unit tests for HardwareDetailsCommitHistoryView and increases the coverage on this file to 100%
Related
Part of #1519