-
Notifications
You must be signed in to change notification settings - Fork 40
Automate incidents creation #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JenySadadia
wants to merge
2
commits into
main
Choose a base branch
from
auto-create-incidents
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Automate incidents creation
Add a subscription module `create_incidents.py` to create incidents automatically when builds and tests objects match with issue patterns. Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| """Automate incident creation""" | ||
| import os | ||
| import kcidb | ||
| from kcidb.tools import kcidb_match | ||
|
|
||
| CLIENT = None | ||
|
|
||
|
|
||
| # pylint: disable=global-statement | ||
| def get_client(): | ||
| """Get KCIDB client instance and set it as a global variable""" | ||
| global CLIENT | ||
| if not CLIENT: | ||
| project_id = os.environ.get('GCP_PROJECT') | ||
| topic_name = os.environ.get('KCIDB_LOAD_QUEUE_TOPIC') | ||
| if project_id and topic_name: | ||
| CLIENT = kcidb.Client(project_id=project_id, topic_name=topic_name) | ||
| return CLIENT | ||
|
|
||
|
|
||
| def match_test(test): | ||
| """Generate incident for matching test""" | ||
| client = get_client() | ||
| if client: | ||
| incident_generator = kcidb_match.IncidentGenerator() | ||
| incidents = incident_generator.generate_incidents_from_test(test) | ||
| client.submit(incidents) | ||
|
|
||
|
|
||
| def match_build(build): | ||
| """Generate incident for matching build""" | ||
| client = get_client() | ||
| if client: | ||
| incident_generator = kcidb_match.IncidentGenerator() | ||
| incidents = incident_generator.generate_incidents_from_build(build) | ||
| client.submit(incidents) | ||
|
|
||
|
|
||
| def match_issue(issue): | ||
| """Match issue and add its pattern to DB""" | ||
| incident_generator = kcidb_match.IncidentGenerator() | ||
| incident_generator.db.update_patterns(issue) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering that
IncidentGeneratorencapsulates a database client connection, why not create and get it similarly toget_client(), instead of creating a new one for every object matched?