tc kselftest dependencies missing

[bhcopeland]

In GitLab by @broonie1 on May 16, 2022, 14:44 GMT+1:

The kselftest targets are missing tc:

make[3]: Entering directory '/build/stage/linux/tools/testing/selftests/tc-testing'
/bin/sh: 1: llc: not found
clang -I. -I/include/uapi  -Wno-compare-distinct-pointer-types \
	 -O2 -target bpf -emit-llvm -c action.c -o - |      \
llc -march=bpf -mcpu=probe  -filetype=obj -o /tmp/build-work/kselftest/tc-testing/action.o
/bin/sh: 1: clang: not found
/bin/sh: 3: llc: not found
make[3]: *** [Makefile:27: /tmp/build-work/kselftest/tc-testing/action.o] Error 127

Migrated from GitLab: https://gitlab.com/Linaro/tuxmake/-/issues/180

[bhcopeland]

In GitLab by @terceiro on May 16, 2022, 18:10 GMT+1:

if those tests hardcode clang and llc then you need to build then using a clang toolchain. I cannot really include clang in the gcc container images, otherwise this will make those images considerably larger.

[bhcopeland]

In GitLab by @broonie1 on May 31, 2022, 15:58 GMT+1:

I'm not sure this is what I'd expect as a user - I'd expect the toolchain selection to control the build of the normal compiler but this is using llc for BPF stuff (and assuming clang is there but that's a separate thing) so doesn't feel different to missing another library or tool.

Perhaps if there were separate images for kselftest builds? That'd allow a bunch of other kselftest dependencies to be dropped, you'd end up with a bunch more images but at least you'd only pay the cost of downloading the larger images if you're building kselftest. Or alternatively if tuxmake were able to skip things that depend on clang when not using clang, or possibly even push that onto users by allowing them to select which bits of kselftest are built? There's currently no way to control which kselftests are built.

Sorry for the delayed reply, missed this with the other issues.