Fails to clean up overlays

[bhcopeland]

In GitLab by @broonie1 on Feb 13, 2024, 16:58 GMT:

If I run:

tuxmake --target-arch=arm64 --kconfig=defconfig --toolchain=gcc-13 --wrapper=none --environment=KBUILD_BUILD_TIMESTAMP=@1707782361 --environment=KBUILD_BUILD_USER=tuxmake --environment=KBUILD_BUILD_HOST=tuxmake --environment=KCFLAGS=-ffile-prefix-map=/tmp/bisect/work/= --runtime=docker --image=docker.io/tuxmake/arm64_gcc-13 config default kernel modules dtbs dtbs-legacy headers kselftest

This fails with:

rm: cannot remove '/tmp/bisect/out/overlay/workdir/work': Permission denied
Traceback (most recent call last):
File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/home/broonie/git/tuxmake/tuxmake/main.py", line 9, in
run()
File "/home/broonie/git/tuxmake/tuxmake/main.py", line 6, in run
main()
File "/home/broonie/git/tuxmake/tuxmake/cli.py", line 170, in main
build.run()
File "/home/broonie/git/tuxmake/tuxmake/build.py", line 670, in run
self.cleanup()
File "/home/broonie/git/tuxmake/tuxmake/build.py", line 612, in cleanup
self.runtime.cleanup()
File "/home/broonie/git/tuxmake/tuxmake/runtime.py", line 611, in cleanup
subprocess.check_call(["rm", "-rf", str(self.overlay_dir)])
File "/usr/lib/python3.9/subprocess.py", line 373, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['rm', '-rf', '/tmp/bisect/out/overlay']' returned non-zero exit status 1.

The directory /tmp/bisect/out/overlay/workdir/work can't be deleted because it is owned by root.root.

Assignees: stylesen

Migrated from GitLab: https://gitlab.com/Linaro/tuxmake/-/issues/213

[bhcopeland]

In GitLab by @stylesen on Feb 14, 2024, 13:36 GMT:

@broonie1 thanks for reporting this issue.

I tried reproducing this issue and identified when run on a fresh Debian bookworm installation with tuxmake version 1.21.4, as non-root user, I see a different set of permission problems reported but not the ones that you have reported.

On the same note, it will be helpful if you can get us more details such as your host OS version and tuxmake version that you are using. Also, let us know, if you are running these commands as non-root user with docker runtime.

[bhcopeland]

In GitLab by @broonie1 on Feb 14, 2024, 16:34 GMT:

This is Debian oldstable using tip of tree tuxmake

[bhcopeland]

In GitLab by @stylesen on Mar 12, 2024, 12:36 GMT:

This is not reproducible with Debian oldstable and bookworm too.

One possibility is the /tmp/bisect/work/ passed to -ffile-prefix-map is a directory that was not built using tuxmake and the permission issue pops up.