Skip to content

allow setting a single arch in darwin build #28865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmaxim merged 1 commit into from
Feb 5, 2026
Merged

allow setting a single arch in darwin build #28865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 22 additions & 7 deletions packaging/build_darwin.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,25 @@
gopath=${GOPATH:-}
client_dir="$gopath/src/github.com/keybase/client"

"$client_dir/packaging/slack/send.sh" "Starting darwin build"
ARCH="amd64" PLATFORM="darwin" "$client_dir/packaging/prerelease/pull_build.sh"
# NOTE: We build the arm64 version second to get a later timestamp, so it will
# be presented as a later version to your updater. This allows the one-time
# upgrading from the x86 build to the arm64 one.
"$client_dir/packaging/slack/send.sh" "Starting darwin-arm64 build"
ARCH="arm64" PLATFORM="darwin-arm64" "$client_dir/packaging/prerelease/pull_build.sh"
if [[ -n "${ARCH:-}" ]]; then
# If ARCH is specified, only build that one
if [[ "$ARCH" == "amd64" ]]; then
"$client_dir/packaging/slack/send.sh" "Starting darwin build"
ARCH="amd64" PLATFORM="darwin" "$client_dir/packaging/prerelease/pull_build.sh"
elif [[ "$ARCH" == "arm64" ]]; then
"$client_dir/packaging/slack/send.sh" "Starting darwin-arm64 build"
ARCH="arm64" PLATFORM="darwin-arm64" "$client_dir/packaging/prerelease/pull_build.sh"
else
echo "Unknown ARCH: $ARCH (expected amd64 or arm64)"
exit 1
fi
else
# Build both architectures
"$client_dir/packaging/slack/send.sh" "Starting darwin build"
ARCH="amd64" PLATFORM="darwin" "$client_dir/packaging/prerelease/pull_build.sh"
# NOTE: We build the arm64 version second to get a later timestamp, so it will
# be presented as a later version to your updater. This allows the one-time
# upgrading from the x86 build to the arm64 one.
"$client_dir/packaging/slack/send.sh" "Starting darwin-arm64 build"
ARCH="arm64" PLATFORM="darwin-arm64" "$client_dir/packaging/prerelease/pull_build.sh"
fi