Skip to content

Fix outstanding appendGUILogs session in node process (#29001) #29006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisnojima merged 1 commit into from
Mar 10, 2026
Merged

Fix outstanding appendGUILogs session in node process (#29001) #29006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion shared/logger/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,13 @@ class AggregateLoggerImpl {

sendLogsToService = async (lines: Array<LogLineWithLevelISOTimestamp>) => {
if (!isMobile) {
// don't want main node thread making these calls
// don't want main node thread making these calls — the node engine's
// NativeTransport forwards responses to the renderer without processing
// them locally, so RPCs sent from node never get responses.
try {
if (typeof process !== 'undefined' && process.type !== 'renderer') {
return await Promise.resolve()
}
const {hasEngine} = require('../engine/require') as {hasEngine: typeof HasEngineType}
if (!hasEngine()) {
return await Promise.resolve()
Expand Down