Skip to content

make headline message copyable #29187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zoom-ua merged 2 commits into from
Apr 30, 2026
Merged

make headline message copyable #29187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbcd1f0
make headline message copyable
zoom-ua Apr 30, 2026
5bbecd4
selectable in mobile info panel
zoom-ua Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions shared/chat/conversation/messages/message-popup/text.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ const PopText = (ownProps: OwnProps) => {
switch (message.type) {
case 'text':
return message.text.stringValue()
case 'setDescription':
return message.newDescription.stringValue() || undefined
case 'systemGitPush':
switch (message.pushType) {
case T.RPCGen.GitPushType.createrepo:
Expand Down
3 changes: 2 additions & 1 deletion shared/common-adapters/markdown/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export type Props = {
context?: string // metadata used for bookkeeping
children?: string
lineClamp?: LineClampType
selectable?: boolean // desktop - applies to outer container only
selectable?: boolean
smallStandaloneEmoji?: boolean // don't increase font size for a standalone emoji
paragraphTextClassName?: string
preview?: boolean // if true render a simplified version
Expand Down Expand Up @@ -447,6 +447,7 @@ const SimpleMarkdownComponent = React.memo(function SimpleMarkdownComponent(p: M
disallowAnimation,
messageType,
paragraphTextClassName,
selectable,
styleOverride,
virtualText,
}
Expand Down
2 changes: 2 additions & 0 deletions shared/common-adapters/markdown/react.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ interface State {
disallowAnimation?: boolean
messageType?: T.Chat.MessageType
paragraphTextClassName?: string
selectable?: boolean
styleOverride?: StyleOverride
virtualText?: boolean
key?: string | number | undefined
Expand Down Expand Up @@ -335,6 +336,7 @@ const reactComponentsForMarkdownType = {
state.inBlockQuote && markdownStyles.quoteStyleText,
])}
allowFontScaling={state.allowFontScaling}
selectable={state.selectable}
>
{output(node['content'], state)}
</Text>
Expand Down