feat: localize JS keyboard search 🌋#715
Open
darcywong00 wants to merge 5 commits intofix/rebuild-globefrom
Open
feat: localize JS keyboard search 🌋#715darcywong00 wants to merge 5 commits intofix/rebuild-globefrom
darcywong00 wants to merge 5 commits intofix/rebuild-globefrom
Conversation
User Test ResultsTest specification and instructions User tests are not required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implements #658 on top of the epic/i18n-url-scheme branches for #384
This follows on by allowing the JS keyboard search to also be localized.
Reference for JS that didn't require a framework:
https://medium.com/@mihura.ian/translations-in-vanilla-javascript-c942c2095170
Changes
search.js-->search.mjsand addi18n.njsas modules in order to import the JSON files_KEYMANCOM_INCLUDESScreenshots
top of list
bottom of list
Test-bot: skip