fix: handle redirects for paths and files with terminating slashes 🌋#717
Draft
mcdurdin wants to merge 1 commit intofix/search-jsonfrom
Draft
fix: handle redirects for paths and files with terminating slashes 🌋#717mcdurdin wants to merge 1 commit intofix/search-jsonfrom
mcdurdin wants to merge 1 commit intofix/search-jsonfrom
Conversation
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
Bot
changed the title
mcdurdin
force-pushed
the
fix/redirects-for-paths
branch
2 times, most recently
from
22d3d59 to
95b97ef
Compare
Remove the `/` from a path if it refers to a file, and add a `/` if the path refers to a folder (implicit index.md/index.php). Clean up keyboard search which had some assumptions about not including the `/` but that doesn't make sense with this pattern. Test-bot: skip
mcdurdin
force-pushed
the
fix/redirects-for-paths
branch
from
95b97ef to
3471e04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
/from a path if it refers to a file, and add a/if the path refers to a folder (implicit index.md/index.php).Clean up keyboard search which had some assumptions about not including the
/but that doesn't make sense with this pattern.Test-bot: skip