Skip to content

feat(developer): kmc convert typesafety 😎#15860

Open
SabineSIL wants to merge 9 commits intofeat/developer/kmc-convertfrom
feat/developer/kmc-convert-Typesafety
Open

feat(developer): kmc convert typesafety 😎#15860
SabineSIL wants to merge 9 commits intofeat/developer/kmc-convertfrom
feat/developer/kmc-convert-Typesafety

Conversation

@SabineSIL
Copy link
Copy Markdown
Contributor

@SabineSIL SabineSIL commented Apr 20, 2026

In several places in kmc-convert: keylayout->kmn we did not care about return type null or undefined for function return values or parameters. Therefore we got several warnings about possible return types not being assignable to symbols.

Even though they did not affect the code running correctly they have been specified more clearly in this PR.

@keymanapp-test-bot skip

see also:

@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot Bot commented Apr 20, 2026

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Developer
    • Keyman Developer - build : all tests passed (no artifacts on BuildLevel "build")
    • Compiler Regression Tests - build : all tests passed (no artifacts on BuildLevel "build")
    • Keyman Developer (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • kmcomp.zip - build : all tests passed (no artifacts on BuildLevel "build")
    • kmcomp.zip (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
  • Keyboards
    • Test Keyboards - build : all tests passed (no artifacts on BuildLevel "build")

@keymanapp-test-bot keymanapp-test-bot Bot changed the title feat/developer/kmc convert typesafety feat/developer/kmc convert typesafety 😎 Apr 20, 2026
@SabineSIL SabineSIL changed the title feat/developer/kmc convert typesafety 😎 feat(developer):kmc convert typesafety 😎 Apr 21, 2026
@SabineSIL SabineSIL changed the title feat(developer):kmc convert typesafety 😎 feat(developer): kmc convert typesafety 😎 Apr 21, 2026
@SabineSIL SabineSIL marked this pull request as ready for review April 21, 2026 15:44
@keyman-server keyman-server modified the milestones: A19S27, A19S28 Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants