AP-5046 outbox-core package for transactional outbox pattern - #204
Merged
Conversation
kamilwylegala
marked this pull request as draft
September 4, 2024 10:22
kamilwylegala
marked this pull request as ready for review
September 5, 2024 11:48
Collaborator
Author
|
@kibertoad Ready for review. |
kibertoad
reviewed
Sep 5, 2024
kibertoad
reviewed
Sep 5, 2024
kibertoad
reviewed
Sep 5, 2024
kibertoad
reviewed
Sep 5, 2024
kibertoad
reviewed
Sep 5, 2024
kibertoad
reviewed
Sep 5, 2024
kibertoad
reviewed
Sep 5, 2024
kibertoad
reviewed
Sep 5, 2024
kibertoad
reviewed
Sep 6, 2024
kibertoad
reviewed
Sep 6, 2024
kibertoad
reviewed
Sep 6, 2024
kibertoad
reviewed
Sep 10, 2024
kibertoad
reviewed
Sep 10, 2024
kibertoad
reviewed
Sep 10, 2024
kibertoad
reviewed
Sep 10, 2024
kibertoad
reviewed
Sep 10, 2024
kibertoad
reviewed
Sep 10, 2024
kibertoad
approved these changes
Sep 11, 2024
kibertoad
left a comment
Owner
There was a problem hiding this comment.
Very impressive work, thank you so much!
Collaborator
Author
Thank you, let me work on the test pipeline now 😁 |
Collaborator
Author
|
Ready for release @kibertoad 🎉 |
|
@kibertoad Could we merge this one? 👉👈 |
Owner
|
@jmontoyaa done. should I publish a new version, or we still need to implement anything for the outbox? |
|
Thanks! 🙏 A new version, is not needed at the moment. There's still this PR in draft about the prisma adapter #208 I will mark ticket AP-5046 as done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added few classes in outbox.ts that cover:
I didn't decide to implement
lockedUntilforACKedentries. Now the code that handles entries is wrapped with try-catch, in case of errors we always end up withFAILEDstatus, next execution will pick up such entries until retry count max is reached.