Missing export - #288
Merged
Merged
Conversation
CarlosGamero
marked this pull request as ready for review
June 11, 2025 09:38
kibertoad
pushed a commit
that referenced
this pull request
May 17, 2026
- Strip undefined values when forwarding options to Consumer/Producer: 2.1.0 no longer lets undefined override library defaults (#288), so spreading caller options as-is would silently re-apply defaults for connection-level fields callers intended to control. - Guard reconnect() against re-entry. With 2.1.0 timing, the consumer stream can emit 'Premature close' while the previous reconnect is still tearing the old stream down, which would spawn a second parallel reconnect chain. - isActive/isConnected now check isReconnecting first so the getters stay true throughout the reconnect window, including the brief interval where the underlying consumer is kClosed but our reference hasn't been cleared yet. - Tests for "fail if kafka is not available" pass retries: 0 because 2.1.0 wraps the group-coordinator lookup in the standard retry loop, pushing the failure past the default 5s test timeout. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.