[feature] cargo rm remove deps with a dash instead of an underscore

[mrnossiom]

Hi there,

Context :

We take the lazy_static crate for the sake of the example.
When you use cargo add command to add the dependency but specify it with a dash instead of an underscore, you end up with this message WARN: Added 'lazy_static' instead of 'lazy-static'.

cargo-edit/src/fetch.rs

Lines 74 to 78 in bd49ee2

	let dep = read_latest_version(&crate_versions, flag_allow_prerelease)?;
	if dep.name != crate_name {
	eprintln!("WARN: Added `{}` instead of `{}`", dep.name, crate_name);
	}

This happens because the registry does correct this.

Feature :

Now, when we want to remove a dependency but specify the wrong separator (dash or underscore), it errors out and exit.
Would it be possible to remove a dependency using another separator in cargo rm ? Or would it cost too much to implement ?

I didn't have the time to look deeper in the code, but I can try a PR.

Thanks for any further suggestions or approval.

[epage]

Great idea!

The main question will be is if this is general policy or registry-specific policy. I know that git and path dependencies do not normalize crate names and I'm assuming that is because its a registry policy but we'll have to dig into this to confirm.

[cassaundra]

It does seem like this is still a registry-specific policy. Am I right in understanding that cargo-add in cargo makes a request to the registry to resolve the package name? I can imagine a possible solution to this problem that would involve making a query to the registry, but I can definitely see where that would be surprising behavior to the user.

[epage]

We talked about this a little bit in the last cargo team meeting. See rust-lang/cargo#10729 (comment) for the current plan.

[epage]

Another related issue: rust-lang/cargo#10680