SDL2 bootstrap pulls in SDL2, pulls in SDL_mixer, which currently compiles with timidity which has artistic license.
I'm just leaving it here so it isn't forgotten: Artistic License apparently has requirements to provide instructions where to get the original source code (so for timidity in this case) along with any application that uses it, which I assume 99% of python-for-android users (certainly myself included) weren't aware of. This also goes beyond the usual expected "credit authors & repeat license" requirements which at least devs bothering with licenses at all would be hopefully aware of, since the license file for timidity doesn't include the necessary source code download link
Therefore I suggest timidity should be disabled, given also how few people still use midi
The affected file is the Android.mk right in the SDL_Mixer tarball root, it needs to be patched to disable timidity to fix this
Edit: this would be a breaking change, since timidity is currently enabled right now at least if I'm reading both the SDL_Mixer 2.0.1 (current) or 2.0.4 (to be updated) Android.mk and our patch for it correctly
Edit 2: just to confirm this, I see plenty timidity symbols in libSDL2_mixer.so as actually included in my app when checking with a hex editor, so pretty sure it's included / statically compiled into SDL_Mixer right now on latest python-for-android master (and probably quite a few versions back)
SDL2 bootstrap pulls in SDL2, pulls in SDL_mixer, which currently compiles with timidity which has artistic license.
I'm just leaving it here so it isn't forgotten: Artistic License apparently has requirements to provide instructions where to get the original source code (so for timidity in this case) along with any application that uses it, which I assume 99% of python-for-android users (certainly myself included) weren't aware of. This also goes beyond the usual expected "credit authors & repeat license" requirements which at least devs bothering with licenses at all would be hopefully aware of, since the license file for timidity doesn't include the necessary source code download link
Therefore I suggest timidity should be disabled, given also how few people still use midi
The affected file is the
Android.mkright in the SDL_Mixer tarball root, it needs to be patched to disable timidity to fix thisEdit: this would be a breaking change, since timidity is currently enabled right now at least if I'm reading both the SDL_Mixer 2.0.1 (current) or 2.0.4 (to be updated)
Android.mkand our patch for it correctlyEdit 2: just to confirm this, I see plenty timidity symbols in
libSDL2_mixer.soas actually included in my app when checking with a hex editor, so pretty sure it's included / statically compiled into SDL_Mixer right now on latest python-for-android master (and probably quite a few versions back)