Update __init__.py to support SDL2#1178
Conversation
|
It looks like you only included one small commit, but you mention some other changes. Are some things missing from this PR? |
|
inclement: yeah, I mostly changed the audiostream setup.py, but im not sure how to include that into this since its a different project? |
|
@snuq In general we can include that kind of change by adding a patch to python-for-android, but actually in this case since audiostream is a Kivy project we can just update it. Could you open a PR for audiostream with the changes that you've made? If you mention the url of this issue, github should generate a link between them. |
still not sure how to get that stupid directory...
|
Great, thanks! |
|
dont we still need to fix the include path? for one, if the user is not named 'kivy', it will fail... |
| #need to find a way to fix this in audiostream's setup.py | ||
| raise RuntimeError('Audiostream library is not yet able to configure itself to link against SDL2. Patch on audiostream library needed - any help much appreciated!') | ||
| env['USE_SDL2'] = 'True' | ||
| env['SDL2_INCLUDE_DIR'] = '/home/kivy/.buildozer/android/platform/android-ndk-r9c/sources/android/support/include' |
Indeed, I just came across it, that should be a fix for a next pull request then 😄 |
4 participants
I managed to get audiostream compiled and working using sdl2 on android.
I had to change the setup.py for audiostream, but I need help making my edits be system-independent, and how to make it able to use sdl OR sdl2....
My modified setup.py is over at: https://github.com/snuq/audiostream/blob/master/setup.py
Mostly i changed instances of 'SDL' into 'SDL2', and included '/home/kivy/.buildozer/android/platform/android-ndk-r9c/sources/android/support/include'