Skip to content

Update Docker base image Ubuntu Bionic 18.04 #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreMiras merged 1 commit into from
Sep 16, 2018
Merged

Update Docker base image Ubuntu Bionic 18.04 #1356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# TODO:
# - delete archives to keep small the container small
# - setup caching (for apt, pip, ndk, sdk and p4a recipes downloads)
FROM ubuntu:16.04
FROM ubuntu:18.04

@AndreMiras AndreMiras Sep 6, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be up to date, mainstream, but not too cutting edge, hence the choice for the last Ubuntu LTS.



# get the latest version from https://developer.android.com/ndk/downloads/index.html
Expand Down
2 changes: 1 addition & 1 deletion pythonforandroid/recipes/python3crystax/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@


class Python3Recipe(TargetPythonRecipe):
version = '3.5'
version = '3.6'

@AndreMiras AndreMiras Sep 6, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've bumped the default to 3.6 because Python 3.5 is getting older and 3.6 is the default Python3 version of various distributions including Ubuntu 18.04 LTS.
It's still possible to force specific version with python3crystax==3.6 if needed.

url = ''
name = 'python3crystax'

Expand Down