Skip to content

jpeg: use https: URL instead of git: [pyconfr18]#1392

Merged
tito merged 1 commit into
kivy:masterfrom
goffi-contrib:jpeg_URL
Oct 5, 2018
Merged

jpeg: use https: URL instead of git: [pyconfr18]#1392
tito merged 1 commit into
kivy:masterfrom
goffi-contrib:jpeg_URL

Conversation

@goffi-contrib

Copy link
Copy Markdown
Contributor

This way download can work when non HTTP ports are blocked.

This way download can work when non HTTP ports are blocked.
@tito tito merged commit dd6c5a5 into kivy:master Oct 5, 2018
@tito tito changed the title jpeg: use https: URL instead of git: jpeg: use https: URL instead of git: [pyconfr18] Oct 5, 2018
@AndreMiras

Copy link
Copy Markdown
Member

Well done thanks.
Actually it would be even better to add the version string and download the archive directly rather than cloning.

@tito

tito commented Oct 5, 2018

Copy link
Copy Markdown
Member

There is no linaro package, only git version that's why. After reviewing, we've seen during the sprint that linaro team have faster optim than standard lib. I guess that's why the original commiter used it.

Aka there is no zip or tgz available.

@AndreMiras

AndreMiras commented Oct 5, 2018

Copy link
Copy Markdown
Member

How about https://github.com/libjpeg-turbo/libjpeg-turbo/releases ?
So I mean using the github auto archiving of the repo.
Edit: so basically https://github.com/libjpeg-turbo/libjpeg-turbo/archive/{version}.tar.gz

@tshirtman

Copy link
Copy Markdown
Member

see tito's answer again, that repos has no such archive feature, but has different code than the github one so that's why this one was used this way.

@AndreMiras

Copy link
Copy Markdown
Member

Oh OK, I misread, thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants