Put install_reqs on line so that buildozer's rubbish parsing will work#1413
Merged
Conversation
AndreMiras
previously approved these changes
Oct 19, 2018
AndreMiras
left a comment
AndreMiras
left a comment
Member
There was a problem hiding this comment.
Since it's a bit special hack from buildozer it probably deserves a ticket if not at least a code comment before somebody else breaks it
This is currently making buildozer fail because it tries to parse the line with a regex, refs: kivy/buildozer#722
AndreMiras
force-pushed
the
inclement-patch-1
branch
from
1f1467a to
f0d5dd6
Compare
AndreMiras
approved these changes
Oct 19, 2018
AndreMiras
left a comment
AndreMiras
left a comment
Member
There was a problem hiding this comment.
I've added the comment and edited the commit message to reference the technical debt task and to comply with 50/72 rule
AndreMiras
referenced
this pull request
Oct 19, 2018
This is a first iteration addressing recipes conditional build. In this version all modified recipes are build in batch with no dependency resolution whatsoever. Also recipes are only built against `python3crystax` target and `sdl2` bootstrap. The list of broken recipes is not fully known, but this script will help finding out. If a recipe is known to be broken, it should be added in the `BROKEN_RECIPES` set to be skipped until it gets fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently making buildozer fail because it tries to parse the line with a regex.