doc: add instructions on accessing service argument#1419
Merged
Conversation
Member
|
Sweet! I'll give it a try just now before approving |
AndreMiras
approved these changes
Oct 21, 2018
AndreMiras
left a comment
AndreMiras
left a comment
Member
There was a problem hiding this comment.
works like a charm, well done!
AndiEcker
reviewed
Oct 21, 2018
| The service argument is made available to your service via the | ||
| 'PYTHON_SERVICE_ARGUMENT' environment variable. It is exposed as a simple | ||
| string, so if you want to pass in multiple values, we would recommend using | ||
| the json module to encode and decode mode complex data. |
There was a problem hiding this comment.
"more complex data" instead of "mode complex data"
Member
Author
|
Crumbs. Only saw your comment now. Will fix...:-)
…On Sun, 21 Oct 2018, 15:56 Andreas Ecker, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In doc/source/services.rst
<#1419 (comment)>
:
> @@ -89,6 +89,15 @@ argument, but with the first letter upper case. You must also pass the
``argument`` parameter even if (as here) it is an empty string. If you
do pass it, the service can make use of this argument.
+The service argument is made available to your service via the
+'PYTHON_SERVICE_ARGUMENT' environment variable. It is exposed as a simple
+string, so if you want to pass in multiple values, we would recommend using
+the json module to encode and decode mode complex data.
"more complex data" instead of "mode complex data"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1419 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADYDK4Ahy_ozyChsKwNGI_Q6GaF6iAyHks5unH0ogaJpZM4XyVav>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds explanation and sample code on how to extract the service argument from within the service.