Skip to content

removed mmap from blacklist#1430

Merged
AndreMiras merged 1 commit into
kivy:masterfrom
goffi-contrib:mmap_bl
Oct 24, 2018
Merged

removed mmap from blacklist#1430
AndreMiras merged 1 commit into
kivy:masterfrom
goffi-contrib:mmap_bl

Conversation

@goffi-contrib

Copy link
Copy Markdown
Contributor

mmap was blacklisted, but it is actually useful, e.g. to communicate
between a frontend and a service.
This patch remove it from blacklists.

@AndreMiras

Copy link
Copy Markdown
Member

Thanks,
I've never played with mmap so I can't tell, @tito you initially blacklisted a bunch including mmap in 2b02324 can you review/merge if it's OK?
In the meantime @goffi-contrib can you simply rebase on master so CI is happy? The idea is to make a full CI run to make sure the recipes compile. Here the CI stopped because of the linter.

@tito

tito commented Oct 24, 2018

Copy link
Copy Markdown
Member

I guess it was removed because it didn't compile for android at the time. If it works today, it can be included yep.

@AndreMiras

Copy link
Copy Markdown
Member

Thanks for the feedbak tito.
Well then @goffi-contrib if you only rebase on master so we can check Travis is happy we're good to merge

mmap was blacklisted, but it is actually useful, e.g. to communicate
between a frontend and a service.
This patch remove it from blacklists.
@goffi-contrib

Copy link
Copy Markdown
Contributor Author

@AndreMiras done :)

@AndreMiras AndreMiras left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good thanks!

@AndreMiras AndreMiras merged commit c12dbd6 into kivy:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants