Conditional builds falls back on Python2 if needed#1435
Merged
AndreMiras merged 1 commit intoNov 3, 2018
Merged
Conversation
Merged
Falls back to python2 when tested recipes are python3crystax compatible. This is for instance the case on kivy#1428 where the recipes depend only on python2, hence couldn't be automatically tested. Also updated `vispy` recipe to handle the version string properly, pin it and clean comments. This recipe is a demo case scenario for the conditional build falling back on python2 since `vispy` is not yet compatible with python3crystax. Last, removes the debug flag from the test apps used by the CI as it produces too many logs and halts Travis.
AndreMiras
force-pushed
the
feature/conditional_build_python2_fallback
branch
from
2371911 to
d563fcf
Compare
Member
Author
|
Updated the pull request, removing |
inclement
approved these changes
Nov 3, 2018
AndreMiras
added a commit
to AndreMiras/python-for-android
that referenced
this pull request
Nov 11, 2018
With kivy#1435 we're falling back automatically to python2 if the recipe is incompatible. This is better than maintaining a skip list, because the recipe will still be compiled under python2 on conflicting dependency graph for python3crystax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Falls back to python2 when tested recipes are python3crystax compatible.
This is for instance the case on #1428 where the recipes depend only on
python2, hence couldn't be automatically tested.
Also updated
vispyrecipe to handle the version string properly,pin it and clean comments.
This recipe is a demo case scenario for the conditional build falling
back on python2 since
vispyis not yet compatible with python3crystax.