Skip to content

fix service handling#218

Merged
tito merged 1 commit into
kivy:masterfrom
kived:service-fix
Sep 9, 2014
Merged

fix service handling#218
tito merged 1 commit into
kivy:masterfrom
kived:service-fix

Conversation

@kived

@kived kived commented Mar 14, 2014

Copy link
Copy Markdown
Contributor
  1. Private service does not work. Public service also does not work when specifying a private folder. PythonService seems to always look in the public folder, and the handling in build.py was poor anyway (e.g. always using private dir, without even checking for a private/service dir). I suppose it could check both directories, but until build.py passes that information to the PythonService class or PythonService itself checks both locations it wouldn't really matter.
  2. Service flag does not get set if there is no main.py, however, main.pyo should be valid as well.

@tito

tito commented Sep 9, 2014

Copy link
Copy Markdown
Member

Looks great, thanks

tito added a commit that referenced this pull request Sep 9, 2014
@tito tito merged commit b65f355 into kivy:master Sep 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants