Qt Bootstrap - Adapting to Qt 6.7 release#2990
Merged
Merged
Conversation
- remove QtNative.setEnvironmentVariable in favour of the Java API. - This removes the dependency on QtNative.
Contributor
Author
|
thanks a lot :) |
jithesh82
pushed a commit
to jithesh82/python-for-android
that referenced
this pull request
Aug 19, 2024
* Qt lib.xml - add placeholder for bundled_libs * Qt Bootstrap: Set environment variables - remove QtNative.setEnvironmentVariable in favour of the Java API. - This removes the dependency on QtNative. --------- Co-authored-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
T-Dynamos
pushed a commit
to T-Dynamos/python-for-android
that referenced
this pull request
Nov 1, 2024
* Qt lib.xml - add placeholder for bundled_libs * Qt Bootstrap: Set environment variables - remove QtNative.setEnvironmentVariable in favour of the Java API. - This removes the dependency on QtNative. --------- Co-authored-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make PythonActivity class independent of QtNative.
QtNative is a private class from Qt 6.7 version. The only use of that class in PythonAcitivity is setting the environment variables.
This can also be done with the Android Java API and hence the dependency can be removed.
add a key array named
bundled_libsto libs.tmpl.xmlThis is more of a placeholder. As mentioned in the comment, the same purpose can be done with android.add_libs_* in buildozer.spec file. This does not break the previous versions.