Skip to content

recipes: add new grpcio recipe#3023

Merged
AndreMiras merged 5 commits into
kivy:developfrom
kengoon:grpcio-recipe
Jul 26, 2024
Merged

recipes: add new grpcio recipe#3023
AndreMiras merged 5 commits into
kivy:developfrom
kengoon:grpcio-recipe

Conversation

@kengoon

@kengoon kengoon commented May 28, 2024

Copy link
Copy Markdown
Contributor

fix #2498

@T-Dynamos

Copy link
Copy Markdown
Member

@kengoon Hi!

Can we make this compatible with PyProjectRecipe?

@kengoon

kengoon commented May 28, 2024

Copy link
Copy Markdown
Contributor Author

@T-Dynamos how? is there a guide line? Grpcio does not make use of poetry

@misl6

misl6 commented May 29, 2024

Copy link
Copy Markdown
Member

Hi @kengoon,

Our CI/CD pipeline noticed something that should not happen while building the grpcio recipe.
BTW, better to ensure every new recipe build is isolated and performed via PyProjectRecipe as @T-Dynamos suggested.

Ping me when ready for the final review and a merge.

@kengoon

kengoon commented May 29, 2024

Copy link
Copy Markdown
Contributor Author

@misl6 PyPtojectReciepe requires pyproject.toml file right? I'm now asking how do I go about using that, the guidelines. Because grpcio does not use use pyproject.toml file

'''Recipe for projects which containes `pyproject.toml`'''

@misl6

misl6 commented May 29, 2024

Copy link
Copy Markdown
Member

@misl6 PyPtojectReciepe requires pyproject.toml file right? I'm now asking how do I go about using that, the guidelines. Because grpcio does not use use pyproject.toml file

Ouch, I see they have an issue opened for that.

@T-Dynamos , anything we can do on our side to have an isolated build without pyproject.toml ?

@T-Dynamos

T-Dynamos commented May 30, 2024

Copy link
Copy Markdown
Member

PyProjectRecipe support both build systems.

* Creating isolated environment: venv+pip...
ERROR Source /home/sompath does not appear to be a Python project: no pyproject.toml or setup.py

Also I have built this recipe locally with PyProjectRecipe and it works.

@kengoon

kengoon commented May 30, 2024

Copy link
Copy Markdown
Contributor Author

@T-Dynamos and @misl6 Alright I will see to it. @T-Dynamos can you share a copy of the changes you made to make it work with PyProject

@T-Dynamos

T-Dynamos commented May 30, 2024

Copy link
Copy Markdown
Member

@kengoon

Changes are in GitHub review.

@kengoon

kengoon commented May 30, 2024

Copy link
Copy Markdown
Contributor Author

@T-Dynamos I can't see any reviews here

@kengoon

kengoon commented May 31, 2024

Copy link
Copy Markdown
Contributor Author

@T-Dynamos thanks for your help with the guide on migrating to PyProjectRecipe

@kengoon

kengoon commented May 31, 2024

Copy link
Copy Markdown
Contributor Author

@misl6 a nice ping for you

@T-Dynamos

T-Dynamos commented Jun 1, 2024

Copy link
Copy Markdown
Member

@kengoon You forgot to include use-ndk-zlib-and-openssl-recipe-include.patch:

    patches = ["comment-getserverbyport-r-args.patch", "remove-android-log-write.patch"]

@kengoon

kengoon commented Jun 1, 2024

Copy link
Copy Markdown
Contributor Author

@T-Dynamos oh sh*t

@kengoon

kengoon commented Jun 2, 2024

Copy link
Copy Markdown
Contributor Author

@misl6 ready for you

@AndreMiras AndreMiras left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI is mostly happy on the "Test updated recipes" except for macOS, but it's already better than the previous state of no recipe at all.
Thank you all for the efforts 💪

@AndreMiras AndreMiras merged commit bbc4021 into kivy:develop Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gRPC Recipe Error

4 participants