add custom recipe support [needs py3 testing]#537
Merged
Conversation
inclement
added a commit
that referenced
this pull request
Dec 19, 2015
add custom recipe support [needs py3 testing]
Member
|
I didn't actually test on python3, but since it seems python2 should work fine I guess let's not dawdle and fix it if it turns out wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two additional locations to find recipes.
First, a local recipes folder is checked. This defaults to
./p4a-recipes, and can be set via the command line option--local-recipes/--local_recipes.Next, a user-local folder is checked in the user-local storage (i.e. ~/.local/share/python-for-android/recipes).
Finally, the standard p4a recipes will be checked.
Note that while this works on py2, it will need to be tested on 3.3/3.4 AND 3.5. 3.5 will use the newer
spec_from_file_locationandmodule_from_specmethods inimportlib.util, while 3.3/3.4 will use the older (deprecated?)SourceFileLoader. py2 just uses the simpleimp.load_source.