added recipe libsodium#549
Merged
Merged
Conversation
Member
|
Looks good, especially the good use of the p4a recipe functions. Did you use the online doc for this, and is there anything you think could be put across better? I have several improvements in mind, but hearing what problems people actually had is very useful. Thanks for the contribution! |
Contributor
Author
|
Thanks! I primarily looked at the openssl recipe (old-toolchain vs revamp) as an example of how to migrate a recipe and studied the documentation of p4a and libsodium cross compilation as well. The Recipe class doc is missing (bottom of the doc page) so I found the source code to look at for more information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.