add copy libs option#555
Merged
Merged
Conversation
Member
|
I've allowed merge conflicts to arise here, but I can do the merge manually. Is it necessary to avoid the biglink this way? With python3 I just skipped the biglink entirely, and copying the .so files in their in-place relative positions seemed to work (with python modules), but I didn't fully follow your changes and I probably don't understand the subtlety of the linking anyway. On that note, do you think the python3 method should also be switched to something like this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds copy libs support back to revamp, similar to old toolchain. This copies libraries and shared objects to the APK rather than using biglink to add them to libpymodules.so, which is required for some use cases where C extension modules have naming conflicts.